Make tree master detail dialog styleable by adding css classes #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucas-koehler
commented
Aug 9, 2017
lucas-koehler
commented
- Added style classes to dialog and its child elements
- Adapted tree renderer test cases to changes
* Added style classes to dialog and its child elements * Adapted tree renderer test cases to changes
| this.dialog.appendChild(dialogContent); | ||
| const dialogClose = document.createElement('button'); | ||
| dialogClose.innerText = 'Close'; | ||
| dialogClose.onclick = () => this.dialog.close(); | ||
| dialogClose.classList.add('btn'); |
There was a problem hiding this comment.
Why btn? Shouldn't this be button?
There was a problem hiding this comment.
This makes it compatible to materialize. However, that should be too specific for the general tree renderer. Should I leave it, change it to button or remove it completely? I think having a general button class makes sense.
There was a problem hiding this comment.
No, it's fine. It's just that we have to aggre on a style naming convention. I'd go with button in this case as and our tests already make use this.
* Changed universal CSS class from 'btn' to 'button' for the tree master detail's dialog's buttons
edgarmueller
approved these changes
Aug 16, 2017
edgarmueller
suggested changes
Aug 16, 2017
| this.dialog.appendChild(dialogContent); | ||
| const dialogClose = document.createElement('button'); | ||
| dialogClose.innerText = 'Close'; | ||
| dialogClose.onclick = () => this.dialog.close(); | ||
| dialogClose.classList.add('button'); |
There was a problem hiding this comment.
Sorry, I've missed that the styling registry isn't utilized here. Use JsonForms.stylingRegistry.addStyle to apply the actual styles for the relevant HTML elements.
edgarmueller
approved these changes
Aug 16, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.