Skip to content

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Jul 7, 2025

Description

MemoryReader could only read one field,
Use totalLength to update index and keep reading.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@HCookie HCookie requested review from oiffrig and shahramn July 7, 2025 16:18
@HCookie HCookie self-assigned this Jul 7, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@a488583). Learn more about missing BASE report.

Files with missing lines Patch % Lines
eccodes/highlevel/reader.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #129   +/-   ##
==========================================
  Coverage           ?   33.89%           
==========================================
  Files              ?       16           
  Lines              ?     2679           
  Branches           ?      197           
==========================================
  Hits               ?      908           
  Misses             ?     1755           
  Partials           ?       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shahramn shahramn added the approved-for-ci Approved for CI label Jul 8, 2025
@shahramn shahramn merged commit 5635fea into develop Jul 8, 2025
271 checks passed
@shahramn shahramn deleted the fix/update-index-in-memory-reader branch July 8, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Approved for CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants