Skip to content

Conversation

lopes-gustavo
Copy link

No description provided.

@lopes-gustavo
Copy link
Author

I still need to write tests and make it work with python2

@alexamici
Copy link
Contributor

@lopes-gustavo you don't need to support python2, the project is python 3 only.

I like the support to read from already opened files, but I don't like the remote URL part as it requires to depend from requests that is a big dependency.

I'd suggest you to split the URL support to a different PR.

@shahramn what's your opinion?

@shahramn
Copy link
Collaborator

I agree with Alessandro. We want to minimise the dependencies unless they are absolutely necessary

@FussyDuck
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gustavo Lopes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lopes-gustavo
Copy link
Author

I renamed my account, so I lost access to this repo.
The provided code is public, so if any of you want to merge it or use part of it, you can do it.
If you need me to do anything, please, don't hesitate to ask, I'll gladly help.

shahramn pushed a commit that referenced this pull request Feb 11, 2023
Merge in ECCODES/eccodes-python from fix/check_float to develop

* commit '077b038e121fa86f07b0f1487d0f1f3fcb29bde3':
  Add float test
  Bug fix
  Fetch long for int value
  Fix check for floats and ints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants