Fix unique glyph codes check in getSubsetText #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in string2unicodes() instead getUniqueText() process passed string as a regular one, it doesn't handle unicode properly and will remove code points parts when several code points share the same numeric parts. Ultimately, it will result in wrong code points being pushed to output. The glyphs count will match, not the codes themselves. Fix subset of UTF-16 glyphs (and probably others). Keeping getUniqText() method for backward compatibility / third party packages relying on it.
|
@Moustachos thank you 😄 |
|
Nice :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use getUniqText() for glyphs subset, check for codes uniqueness in string2unicodes() instead.
getUniqueText() process passed string as a regular one. In some cases it doesn't handle unicode properly and will remove code points parts when several code points share the same numeric parts.
Ultimately, it will result in wrong code points being pushed to output.
In some cases, the glyphs count will match, not the codes themselves (tested and confirmed with FontAwesome's Duotone font variation).
Fix UTF-16 glyphs subset (and probably others), tested and confirmed with FontAwesome's Duotone font variation where glyphs code points look like this: \10f6ae (https://fontawesome.com/v5.15/icons/acorn?style=duotone).
Keeping getUniqText() method for backward compatibility / third party packages relying on it.