-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to filter optimized fonts with an allowlist and a skiplist #48
Allow to filter optimized fonts with an allowlist and a skiplist #48
Conversation
Add two options: allowedFilesRegex & skippedFilesRegex. Both can be null or RegExp, they're mutually exclusive and allowedFilesRegex has priority over skippedFilesRegex. Fix patrickhulce#29 Fix patrickhulce#5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Moustachos, looks great ! could you add a quick test for this?
There you go :) |
thanks @Moustachos ! |
heads up @Moustachos we have a lint failure, but LGTM other than that |
@patrickhulce it should be fixed now |
@patrickhulce could you merge this one when you got some time? I also made a pull request on Fontmin lib to address a bug where invalid code points are pushed to output, due to of how code points uniqueness is checked (ecomfe/fontmin#92). It's been merged in 0.9.9 so if you could upgrade it while you're at it, it would be sweet 👍 |
thanks for the ping @Moustachos! |
Add two options: allowedFilesRegex & skippedFilesRegex.
Both can be null or RegExp, they're mutually exclusive and allowedFilesRegex has priority over skippedFilesRegex.
Usage example (to only target FontAwesome):
Fix #29
Fix #5