Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConsGenIncProcessModel.py #1072

Merged
merged 4 commits into from
Oct 19, 2021
Merged

Conversation

alanlujan91
Copy link
Member

@alanlujan91 alanlujan91 commented Oct 19, 2021

Implements calc_expectation on ConsGenIncProcessSolver.

  • [NA] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • [NA] Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #1072 (4c62b52) into master (d59269d) will decrease coverage by 0.02%.
The diff coverage is 86.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   72.53%   72.51%   -0.03%     
==========================================
  Files          68       68              
  Lines       10298    10304       +6     
==========================================
+ Hits         7470     7472       +2     
- Misses       2828     2832       +4     
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsGenIncProcessModel.py 82.31% <84.78%> (-0.87%) ⬇️
...umptionSaving/tests/test_ConsGenIncProcessModel.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59269d...4c62b52. Read the comment docs.

@sbenthall
Copy link
Contributor

This looks good to me!
I think it just needs a changelog entry and then it's ready to merge.

@alanlujan91
Copy link
Member Author

Done!

@sbenthall sbenthall merged commit eb611e6 into econ-ark:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants