Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
IndexDstn
makes its random-number-generation work slightly different to what the majority of the HARK code currently does. Find the details in the discussion in #1024.There is no right or wrong way to handle the RNG. Some might prefer what IndexDstn does, others might prefer what the legacy HARK code does. In the end both ways of doing things
a) Represent the same distributions when solving the agents' problems.
b) Draw shocks that follow the same (correct) distributions.
The issue is that the exact value of individual shocks is altered when one tries to replace legacy HARK code with the newer
IndexDstn
tool, and this breaks simulation tests.This PR changes
IndexDstn
so that the user has the option of creating a new RNG (current behavior) or use an existing one (legacy HARK tests) to draw the seeds of the time-specific distributions that compose theIndexDstn
.This (I hope) will allow me to use
IndexDstn
and still pass tests. Eventually, if one random-number-generation method is favored over the others, we can go back and alter the tests accordingly (being sure that changes come only from RNG).Please ensure your pull request adheres to the following guidelines: