Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AgentPopulation #1237

Merged
merged 26 commits into from
Apr 26, 2023
Merged

Conversation

alanlujan91
Copy link
Member

@alanlujan91 alanlujan91 commented Mar 8, 2023

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.04 🎉

Comparison is base (9167a76) 73.31% compared to head (620d3c3) 73.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1237      +/-   ##
==========================================
+ Coverage   73.31%   73.35%   +0.04%     
==========================================
  Files          76       76              
  Lines       12551    12705     +154     
==========================================
+ Hits         9202     9320     +118     
- Misses       3349     3385      +36     
Impacted Files Coverage Δ
HARK/core.py 88.40% <73.13%> (-4.92%) ⬇️
HARK/tests/test_core.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@llorracc llorracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe distribution_type_index and distribution_type_discrete_timevarying?

The people at Wolfram have thought long and hard about all of this stuff and have a nice schema for specializing generic distributions to specific cases in Mathematica.

@alanlujan91 alanlujan91 merged commit 39b52bb into econ-ark:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants