classes to represent continuous distributions for simulation draws #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The HARK builds are failing here due to some kind of GitHub checkout error? |
|
Wooooo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an incremental step towards #611 , this PR refactors the
draw_functions insimulation.pyso that each one is encapsulated in a class (Normal,Bernoulli, etc.)Draws are now accomplished by using the
drawmethod on a class initialized with the appropriate parameters.This brings the HARK programming idioms closer to mathematical invocations of random variables.
It also brings HARK closer in line with best practices for representing distributions in other libraries, such as Dolo.