Fix DiscreteDstn #646
Merged
Fix DiscreteDstn #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of drawDiscrete did not work properly when the distribution was multivariate. That's now fixed, returning a JxN array of draws (where J is the dimension of the distribution). It also seemed to have a typo/error, referring to Xdim, which does not exist. This commit does not make drawDiscrete work when the input X is an integer, but it didn't work before either.
Fixed makeAggShockDstn() to work properly with new format.
sbenthall
reviewed
Apr 23, 2020
|
|
||
| if exact_match: | ||
| # Set up the RNG | ||
| RNG = np.random.RandomState(seed) | ||
|
|
There was a problem hiding this comment.
I'm confused-- why did you move the RNG setting into exact_match?
|
Ideally, this PR would come with an automated test catching the case that was originally broken. That would be very helpful because I expect that the |
|
I didn't get around to writing this test yet.
…On Fri, May 1, 2020 at 9:51 AM Sebastian Benthall ***@***.***> wrote:
Merged #646 <#646> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#646 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFJONBGEWJ5V4L57LLTRPLHVXANCNFSM4MPEB77A>
.
|
|
I saw that. I figured it was better to have the fix in than not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscreteDstn wasn't working properly with multivariate distributions. This PR makes some small fixes to it.