Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move file manipulation methods into helpers.py #662

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

sbenthall
Copy link
Contributor

core.py has contained some methods for copying modules on the file system and somesuch.

Elsewhere, @llorracc has expressed the idea that methods that should help with the configuration of the Python environment or Jupyter notebooks should go in the HARK library somewhere.

These sorts of functions are of a very different character from the model code and it doesn't make much sense for them to be sitting side by side.

This PR moves this code from core to a new module helpers where it will be out of the way.

(it also removes the dummy main() method from core.py, which is unnecessary)

@mnwhite
Copy link
Contributor

mnwhite commented Apr 28, 2020

All of our HARK.blah modules (used to?) have dummy main blocks that printed a message indicating they don't do anything, as in its old form all of the files would be in the user's working directory, and Chris wanted to be sure that something happened if a user hit run on any file.

@mnwhite mnwhite merged commit 588dea3 into econ-ark:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants