remove cstwMPC from HARK codebase, bye bye #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should let @mnwhite actually execute the merge, just to give him the satisfaction of finally accomplishing a long-sought goal. But @sbenthall can review first. |
|
this passes my review. |
|
Hold on, trying to come up with the perfect meme to link here. This is
important.
…On Tue, Apr 28, 2020 at 5:02 PM Sebastian Benthall ***@***.***> wrote:
this passes my review.
@mnwhite <https://github.com/mnwhite> please do the honors at your
convenience
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#666 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFOWX4KP63L7BULFUH3RO476NANCNFSM4MTBE3NQ>
.
|
|
@mnwhite you might lose your privileges to merge this if you don't find a meme fast enough! |
|
Yeah just go ahead.
…On Thu, Apr 30, 2020 at 11:59 AM Christopher Llorracc Carroll < ***@***.***> wrote:
@mnwhite <https://github.com/mnwhite> you might lose your privileges to
merge this if you don't find a meme fast enough!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#666 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFJJGZE5FTSF7S6S24LRPGN5LANCNFSM4MTBE3NQ>
.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #449 #415
cstwMPC stays as a REMARK and datasets moved to HARK.datasets.