Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters back to ConsLaborModel and fix up to match new distribution code #729

Merged
merged 5 commits into from
Jun 25, 2020

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Jun 24, 2020

addresses #721, #684, #681

@MridulS MridulS requested a review from mnwhite June 24, 2020 22:26
@MridulS
Copy link
Member Author

MridulS commented Jun 24, 2020

As this runs black on the codebase it may have added too much to the files changed tab, so have a look at the specific commits

e3d6f2d (changes to ConsLaborModel)

and

5c43e02 (adds tests)

to review this PR. :)

@MridulS MridulS requested a review from sbenthall June 24, 2020 22:50
class test_LaborIntMargConsumerType(unittest.TestCase):
def setUp(self):
self.model = LaborIntMargConsumerType()
self.model_finte_lifecycle = LaborIntMargConsumerType(**init_labor_lifecycle)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finte -> finite ?

@sbenthall
Copy link
Contributor

I'm loving the blackify style.

@sbenthall
Copy link
Contributor

This looks good to me except for the typo in the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants