Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #907.
Currently in this PR, only
core.py
has been converted over.This is mainly a matter of automated Find and Replace and making sure tests pass.
One change: the original
core.py
had a variableread_shocks
and a methodreadShocks
. In order to avoid name conflict, The method is now namedread_shocks_from_history
.Will look this over with others on Thursday and assuming it passes first inspection, I'll do the rest of the library.