Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 for names #953

Merged
merged 4 commits into from
Feb 25, 2021
Merged

PEP8 for names #953

merged 4 commits into from
Feb 25, 2021

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Feb 16, 2021

Addressing #907.

Currently in this PR, only core.py has been converted over.
This is mainly a matter of automated Find and Replace and making sure tests pass.

One change: the original core.py had a variable read_shocks and a method readShocks. In order to avoid name conflict, The method is now named read_shocks_from_history.

Will look this over with others on Thursday and assuming it passes first inspection, I'll do the rest of the library.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@codecov-io
Copy link

codecov-io commented Feb 16, 2021

Codecov Report

Merging #953 (5d9b836) into master (c6b3b22) will not change coverage.
The diff coverage is 85.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   71.43%   71.43%           
=======================================
  Files          62       62           
  Lines        9145     9145           
=======================================
  Hits         6533     6533           
  Misses       2612     2612           
Impacted Files Coverage Δ
HARK/datasets/SCF/WealthIncomeDist/SCFDistTools.py 78.04% <ø> (ø)
HARK/estimation.py 0.00% <0.00%> (ø)
HARK/ConsumptionSaving/ConsIndShockModelFast.py 51.05% <30.00%> (ø)
HARK/interpolation.py 41.06% <31.57%> (ø)
HARK/distribution.py 79.86% <76.19%> (ø)
HARK/dcegm.py 49.25% <81.81%> (ø)
HARK/ConsumptionSaving/ConsPortfolioModel.py 67.27% <85.00%> (ø)
HARK/core.py 89.59% <88.28%> (ø)
HARK/ConsumptionSaving/ConsIndShockModel.py 83.39% <89.65%> (ø)
HARK/utilities.py 32.23% <90.90%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b3b22...5d9b836. Read the comment docs.

@sbenthall sbenthall mentioned this pull request Feb 23, 2021
3 tasks
@sbenthall sbenthall changed the title [WIP] PEP8 for names PEP8 for names Feb 23, 2021
@sbenthall sbenthall added this to the 1.0.0 milestone Feb 23, 2021
@sbenthall sbenthall merged commit a3f7310 into econ-ark:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants