DurableConsumerType #139
DurableConsumerType #139
Conversation
There was a problem hiding this comment.
@AMonninger, this is work-in-progress, right? If so, can you rename it to [WIP] DurableConsumerType?
Or, is this ready to merge?
This is ready to merge. It is only the meta data file. The repository is on my github account (which is WIP). |
|
I saw that it was a metadata file -- my real question was whether the
REMARK on your own GitHub site is ready to go, or if it is work in
progress. Like, was the stuff you were talking about today part of it? In
that case, it's still WIP.
…On Fri, Jan 13, 2023 at 2:46 PM AMonninger ***@***.***> wrote:
@AMonninger <https://github.com/AMonninger>, this is work-in-progress,
right? If so, can you rename it to [WIP] DurableConsumerType?
Or, is this ready to merge?
This is ready to merge. It is only the meta data file. The repository is
on my github account.
—
Reply to this email directly, view it on GitHub
<#139 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKCK7Y2SD4IFBWAQLORDVTWSGWJHANCNFSM6AAAAAAQCXET34>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
- Chris Carroll
|
This REMARK is the HARKified version of Jeppes code. I'm working on a different repository and improve the code. Once that is done, I will update the REMARK and showcase the improvements. I would merge it now and make the update version 2... |
|
Great, yes, let's make it a public REMARK. If we have done our job right, you should be able to easily find the instructions required to put it over the finish line as a public draft REMARK. If you can't find them, or if they are incomplete or unclear, please contact @camriddell who is working to improve our REMARK procedures. |
|
@camriddell , @llorracc says it would be ready to become a REMARK. |
|
Everything appears to be in order in my perspective. I'll go ahead and merge this and then add it to the website as well. Should be up by early next week if not sooner. |
|
@AMonninger a quick update before we merge, can you add a Here is an example for what the content of this file should look like. You can include this in your root directory alongside the |
|
@camriddell done! |
|
@AMonninger, if you're running this using python 2.7, please try it on python 3.10 and see if it still works. We've abandoned python 2.7 long ago. |
|
@AMonninger thank for updating the Can you add the version of seaborn you are using to the |
|
Added. @camriddell thanks for the testrun! |
|
@AMonninger, and can you see if it works with python 3.10? Or, if not, if it's easy to fix? |
|
Upgrading to |
|
OK, go for it.
…On Tue, Jan 24, 2023 at 11:16 AM Cameron ***@***.***> wrote:
Upgrading to 3.10 at the very least will require newer versions of numpy.
I think since this works as is now, we should go ahead and accept this in
its current state and then start a PR for an upgrade process if desired?
—
Reply to this email directly, view it on GitHub
<#139 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKCK74ZQHBEMQSZ7HYC3ATWT755FANCNFSM6AAAAAAQCXET34>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
- Chris Carroll
|
|
@camriddell I received a message that a run failed and looked into it. I updated the requirements and it should work now. |
|
@camriddell, I think Adrian may need to demo this notebook on Friday, so if you can merge the working version before you depart for Hawaii, that would be great! |
|
Hi all, mybinder.org seems to be having an issue with this repository right now. I would encourage you to try again tomorrow to see if it is working (the binder build worked for me yesterday on this repo). In the meantime, I was able to use
Note that the above links won't have your most recent commit I was also able to get this repository to build locally using the same tool binder uses: |
Adding DurableConsumerType.md which can be found: https://github.com/AMonninger/DurableConsumerType_REMARK