Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py so module can be installed. #85

Closed
theoldfather opened this issue Sep 29, 2016 · 8 comments
Closed

Add setup.py so module can be installed. #85

theoldfather opened this issue Sep 29, 2016 · 8 comments

Comments

@theoldfather
Copy link

No description provided.

@mnwhite
Copy link
Contributor

mnwhite commented Sep 29, 2016

This has been discussed and an early version was developed. I believe we decided to hold off on this for a while, but now I forget our reasoning. Leaving open for others to fill in details.

@brainwane
Copy link
Contributor

I'm working on this in https://github.com/brainwane/HARK/tree/installability which I should have linked here much earlier - apologies! I should have it merged into master later today.

@brainwane
Copy link
Contributor

We have some early developer releases available for pip install at http://pypi.org/project/econ-ark and conda install at https://anaconda.org/sumanah-changeset/econ-ark .

@mnwhite
Copy link
Contributor

mnwhite commented Jun 7, 2018

Before merging the installability branch into master, can we fix the Models vs Demos issue?

@brainwane
Copy link
Contributor

Thank you for that very good point, @mnwhite!

The Models versus Demos issue @mnwhite mentioned is: in the installability branch, we've changed the structure of the code, with several commits by @jasonaowen -- some of which he'd like to do over, reverting how he separated out Demos.

@compumetrika asked when we were planning on merging the installability branch back into master, and I originally suggested doing it this week. But @mnwhite makes a good point: it would be nice to have only one giant breaking change in master instead of two in a row. We do have some time pressure here, since we want to get this all merged and tested, and cut a new release, before Tuesday, 19 June (when Chris and Matt do their next public demo).

So here's how I propose to do this:

  • Today, I'll make a separate pull request with other cleanup that's immediately applicable to the master branch.
  • Tomorrow, I'll further prepare installability to make it more ready to merge into master.
  • Next week, starting Monday, Jason will address the Models vs Demos issue on installability.
  • After he's done that, ideally in the middle of next week, we make a pull request to merge installability into master, and get that reviewed and merged.

@mnwhite
Copy link
Contributor

mnwhite commented Jun 7, 2018

(Non-code note: I'm back stateside. Chris is doing the Bank of England and Venice presentations solo!)

@mnwhite
Copy link
Contributor

mnwhite commented Jun 7, 2018

This sounds really great. It's not your job to do it, but as a note for other team members (i.e. Nathan):

The next step after installability is merged in is to remove cstwMPC, cAndCwithStickyE, SolvingMicroDSOPs, and all of the Demos from HARK. When HARK is a package, those applications should not be installed. They will be provided separately on Econ-ARK as standalone archives and import the installed HARK.

@mnwhite
Copy link
Contributor

mnwhite commented Jun 7, 2018

And because CDC keeps asking what we can call HARK 1.0: ^^^^ THAT! is HARK 1.0. A real package from which real research applications import their core functionality, extend it, and do their thing.

The time is near, get hyped!

jasonaowen added a commit that referenced this issue Jun 14, 2018
In support of finding dependencies and transitive dependencies that make
packaging HARK more difficult, remove some of the import statements that
bring in dependencies that are not used in the code, as detected by
flake8:

    git ls-files '*.py' | xargs flake8 --select=F401

In particular, some of the apparently-unused imports not removed are due
to usages flake8 can't detect, such as the fact that the
HARKutilities.warnings import has side effects, or the `exec()` use of
`copy.copy`.

Issue #85 Add setup.py so module can be installed
jasonaowen pushed a commit that referenced this issue Jun 14, 2018
Make HARK packagable, so maintainers can make source distributions to
distribute to PyPI (for pip installation) and conda packages to
distribute to Anaconda.org (for conda installation).

Add manifest, setup.py, setup.cfg, and requirements.txt file.

Indicate that some papers are excluded.

HARK and the Econ-ARK are under development, so a pre-release version
identifier per PEP 440[1] is appropriate.

[1] https://www.python.org/dev/peps/pep-0440/#pre-releases

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
As we move files around, it is helpful not to have extraneous,
commented-out code.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Rename the parallel module, and refer to it by its new name in all the
code in the repo that currently refers to it.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Rename the utilities module, and refer to it by its new name in all the
code in the repo that currently refers to it.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Rename the simulations module, and refer to it by its new name in all the
code in the repo that currently refers to it.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Rename the core module, and refer to it by its new name in all the code
in the repo that currently refers to it.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Use the newly-packaged HARK instead of adding the path(s) of needed
modules to the import path.

This now requires HARK to be pip- or conda-installed. You can pip
install from the root of the repository with `pip install .`.

Issue #85 Add setup.py so module can be installed
jasonaowen pushed a commit that referenced this issue Jun 14, 2018
Make HARK packagable, so maintainers can make source distributions to
distribute to PyPI (for pip installation) and conda packages to
distribute to Anaconda.org (for conda installation).

Add manifest, setup.py, setup.cfg, and requirements.txt file.

Indicate that some papers are excluded.

HARK and the Econ-ARK are under development, so a pre-release version
identifier per PEP 440[1] is appropriate.

[1] https://www.python.org/dev/peps/pep-0440/#pre-releases

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
As we move files around, it is helpful not to have extraneous,
commented-out code.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Rename the parallel module, and refer to it by its new name in all the
code in the repo that currently refers to it.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Rename the utilities module, and refer to it by its new name in all the
code in the repo that currently refers to it.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Rename the simulations module, and refer to it by its new name in all the
code in the repo that currently refers to it.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Rename the core module, and refer to it by its new name in all the code
in the repo that currently refers to it.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Use the newly-packaged HARK instead of adding the path(s) of needed
modules to the import path.

This now requires HARK to be pip- or conda-installed. You can pip
install from the root of the repository with `pip install .`.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Use the newly-packaged HARK instead of adding the path(s) of needed
modules to the import path.

This now requires HARK to be pip- or conda-installed. You can pip
install from the root of the repository with `pip install .`.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 14, 2018
Use the newly-packaged HARK instead of adding the path(s) of needed
modules to the import path.

This now requires HARK to be pip- or conda-installed. You can pip
install from the root of the repository with `pip install .`.

Issue #85 Add setup.py so module can be installed
jasonaowen added a commit that referenced this issue Jun 15, 2018
HARK.core contains the most important bits of HARK. Expose those bits
under the "HARK" namespace, rather than requiring users to know about
"HARK.core". This allows user to, for example, `from HARK import
AgentType` rather than `from HARK.core import AgentType`.

Issue #85 Add setup.py so module can be installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants