Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added x86_64 with working test. #139

Merged
merged 2 commits into from
May 12, 2023
Merged

Added x86_64 with working test. #139

merged 2 commits into from
May 12, 2023

Conversation

arnejohannesholmin
Copy link
Contributor

No description provided.

@arnejohannesholmin arnejohannesholmin mentioned this pull request May 12, 2023
Closed
eddelbuettel
eddelbuettel requested changes May 12, 2023
View reviewed changes
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good and diligent.

You let two files .DS_Store slip in. That is a macOS thing. Can you see of if you can git rm them (and maybe add the .DS_store pattern to `.gitignore") ?

eddelbuettel
eddelbuettel approved these changes May 12, 2023
View reviewed changes
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work

@eddelbuettel eddelbuettel merged commit 8c1194c into eddelbuettel:master May 12, 2023
@eddelbuettel eddelbuettel mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnejohannesholmin @eddelbuettel