-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style bibliography (when link-citations: false) #47
Conversation
Woot. Sounds promising. Could you maybe (cough, cough, we usually hate screenshots) show a quick 'before' and 'after' ? |
That's tough. I kinda like them both and want to remain faithful to the old 'compact' display too. Do you think we could make it a yaml header switch? I can see us picking up the value and than maybe switching css files in |
Personally I think the old style just looks broken and unstyled (and it sort of is). It extends wider than the rest of the content. Maybe tweak the width so it spans both the content and margin areas, and reduce the spacing between the bib items? |
I'll have to look in more detail and can't do that right now -- but point taken on the width. We'll make this better. (I am mostly a pdf user so feedback and help is appreciated!) |
Can describe which document you rendered with which version of @jonathan-g Any views on the styling matters and preferences? |
I added the References header myself with a |
Well we are five messages back and forth in yet we still have not minimally complete and reproducible example. Could you please add one? |
---
title: Minimal working example
output: tint::tintHtml
bibliography: mwe.bib
link-citations: no
---
```{r include=FALSE}
knitr::write_bib(c('base', 'tint', 'knitr'), file = 'mwe.bib')
```
We refer to the packages by @R-base, @R-tint and @R-knitr.
```{css, eval=FALSE, echo=FALSE}
.csl-bib-body {
width: 85%;
margin-top: 1.4rem;
}
.csl-entry {
margin: .25rem 0;
line-height: 1.5;
}
```
# References Toggle |
This is so much better :) I also added it to the bottom of the included I am with you that this needs a little work. But
|
All sounds good to me. The main text seems to use between 55% and 60% (depending on whether it's a |
My bad. I only tried 1.0rem and it is too indiscernible. What should we use? 3? 5? |
I have no strong preference. Only consideration would be if anything is ever likely to appear below the bibliography. But I don't think anything ever does, as footnotes always appear in the margin, right? |
Right. Unless overridden. I put three there then. |
I just updated your PR -- can you double check that is what we want? I
|
Just tried it out and it looks good to me! |
Thanks for suggesting this. Clearly makes it better. Will merge this. |
I didn't like the look of the references section if I had
link-citations: false
in the YAML andoutput: tint::tintHtml
i.e. when references appear at the end of the document rather than as sidenotes. The entries were too close together with inadequate line spacing. This PR tweaks the CSS slightly so the references look a little bit nicer - that's all.