fix: UpdateDTO accept empty Id if the name is provided #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation should pass if the Name is provided and the Id field is empty string in the update DTO. Close edgexfoundry#640 Signed-off-by: weichou <weichou1229@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #648 +/- ##
=======================================
Coverage 62.54% 62.54%
=======================================
Files 75 75
Lines 2753 2753
=======================================
Hits 1722 1722
Misses 866 866
Partials 165 165 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #640
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.
What is the current behavior?
The validation would be failed if the Id field is empty string in the update DTO.
Issue Number: #640
What is the new behavior?
The validation should pass if the Name is provided and the Id field is empty string in the update DTO.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information