Handle binary/octet-stream content type
#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some recent additions to our upload script are now storing response bodies in S3 with the content type `binary/octet-stream`. This appears to be a change in boto3 (the AWS SDK), where it is now using that as a generic content type instead of `application/octet-stream`. This new type is not actually valid; I'm not sure why they're doing it, but this is functionally the same, and should not cause us to consider something as "definitely not HTML". (Obviously we should fix the upload script, too, but that is a secondary concern.)
Mr0grog
added a commit
to edgi-govdata-archiving/web-monitoring-ops
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent additions to our upload script (edgi-govdata-archiving/web-monitoring-processing#855) are now storing response bodies in S3 with the content type
binary/octet-stream. This isn’t a valid media type (it should beapplication/octet-stream), and this appears to be a change in boto3 (the AWS SDK) or maybe a difference between it and AWS SDKs for other languages. Regardless, we now have data stored this way and we should handle it the same asapplication/octet-stream(essentially: this content-type tells us nothing one way or the other, so ignore it).Obviously we should fix the upload script, too, but that is a secondary concern vs. actual data we have stored.