use :poolboy.status to get free workers #67
Conversation
|
Changes Unknown when pulling 8e6e1aa on mitchellhenke:poolboy_full into * on edgurgel:master*. |
| @@ -193,6 +193,8 @@ defmodule Verk.WorkersManager do | |||
| Log.start(job, worker) | |||
| Verk.Worker.perform_async(worker, self, job) | |||
| notify!(%Events.JobStarted{job: job, started_at: Timex.DateTime.now}) | |||
| :full -> | |||
| Verk.enqueue(job) | |||
There was a problem hiding this comment.
It's not that simple. We should never ask for jobs if we don't have a free worker. To push back a job we need to remove from the inprogress list as well. Dequeuing a job is done by this: https://github.com/edgurgel/verk/blob/master/priv/mrpop_lpush_src_dest.lua
So if we "need" to reenqueue a job I would rather consider this an invalid state that we got to and it's a bug.
There was a problem hiding this comment.
should I remove this clause?
This should be unnecessary now that poolboy is used to determine how many available workers there are?
There was a problem hiding this comment.
I think so. We should always get the amount of workers we know that poolboy has. It should never be less than the amount we just asked for I guess.
There was a problem hiding this comment.
Makes sense. Dropped that part of the case clause.
mitchellhenke
force-pushed
the
poolboy_full
branch
from
8e6e1aa
to
dc42370
Compare
|
Changes Unknown when pulling dc42370 on mitchellhenke:poolboy_full into * on edgurgel:master*. |
|
Changes Unknown when pulling 4fafb41 on mitchellhenke:poolboy_full into * on edgurgel:master*. |
|
Thanks! 🎉 |
|
Released as part of https://github.com/edgurgel/verk/releases/tag/v0.11.1 |
To fix #59