Skip to content

PHP7 Supports #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2015
Merged

PHP7 Supports #11

merged 6 commits into from
Aug 7, 2015

Conversation

laruence
Copy link

@laruence laruence commented Aug 7, 2015

Hey:

This is a under working PR which try to make this extension works with PHP7.

Sorry for saying this, but I must say, the current implementation is really mess, and it must not works....

1. Cods style is mess (variable name, useless comments, indents etc)
2. The codes is not completely right, there even are some codes returns stack allocated zvals.
3. No tests scripts(phpt files).... I even don't know does it work or not. 
4. Most of these mistakes are in cluster relates codes.

Anyway, I hope I can make this a little better, but I am afraid I don't have much time on this...

thanks

@laruence
Copy link
Author

laruence commented Aug 7, 2015

nevermind, I will make a PR against phpredis/phpredis instead... thanks

@laruence laruence closed this Aug 7, 2015
@edtechd edtechd reopened this Aug 7, 2015
edtechd added a commit that referenced this pull request Aug 7, 2015
PHP7 Support improvement
@edtechd edtechd merged commit c3e443b into edtechd:php7 Aug 7, 2015
@edtechd
Copy link
Owner

edtechd commented Aug 7, 2015

Hi! Well done! Thank you! I have merged your changes to this repo.

@laruence
Copy link
Author

@edtechd oh, great, thanks for the merging...... but...it is till underworking..(I even didn't test it). I tried to merge this to the phpredis/phpredis repo, but lots of conflicts... :<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants