chore: Enterprise Checkout MFE allowed to POST to enterprise-access #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates CSRF trusted origins configuration across multiple services to allow the Enterprise Checkout MFE to make POST requests. The changes standardize the configuration by replacing hardcoded localhost URLs with environment variables and explicitly add the Enterprise Checkout MFE to the allowed origins.
- Replaced hardcoded localhost URLs with environment variables in LMS and CMS CSRF configuration
- Added Enterprise Checkout MFE (localhost:1989) to CORS and CSRF trusted origins in enterprise-access service
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| py_configuration_files/lms.py | Replaced hardcoded localhost URLs with environment variables for CSRF trusted origins |
| py_configuration_files/enterprise_access.py | Added Enterprise Checkout MFE to both CORS and CSRF trusted origins |
| py_configuration_files/cms.py | Replaced hardcoded localhost URLs with environment variables for CSRF trusted origins |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pwnage101
changed the title
pwnage101
commented
Aug 21, 2025
Comment on lines
-554
to
566
| 'http://localhost:2001', # frontend-app-course-authoring | ||
| 'http://localhost:1997', # frontend-app-account | ||
| 'http://localhost:1995', # frontend-app-profile | ||
| 'http://localhost:1992', # frontend-app-ora | ||
| 'http://localhost:2002', # frontend-app-discussions | ||
| 'http://localhost:1991', # frontend-app-admin-portal | ||
| 'http://localhost:8734', # frontend-app-learner-portal-enterprise | ||
| 'http://localhost:1989', # frontend-app-enterprise-checkout | ||
| 'http://localhost:1999', # frontend-app-authn | ||
| ACCOUNT_MICROFRONTEND_URL, # frontend-app-account | ||
| PROFILE_MICROFRONTEND_URL, # frontend-app-profile | ||
| ORA_MICROFRONTEND_URL, # frontend-app-ora | ||
| DISCUSSIONS_MICROFRONTEND_URL, # frontend-app-discussions | ||
| ENTERPRISE_ADMIN_PORTAL_BASE_URL, # frontend-app-admin-portal | ||
| ENTERPRISE_LEARNER_PORTAL_BASE_URL, # frontend-app-learner-portal-enterprise | ||
| ENTERPRISE_CHECKOUT_BASE_URL, # frontend-app-enterprise-checkout | ||
| AUTHN_MICROFRONTEND_URL, # frontend-app-authn | ||
| 'http://localhost:18450', # frontend-app-support-tools | ||
| 'http://localhost:1994', # frontend-app-gradebook | ||
| 'http://localhost:1996', # frontend-app-learner-dashboard | ||
| LEARNING_MICROFRONTEND_URL # frontend-app-learning | ||
| WRITABLE_GRADEBOOK_URL, # frontend-app-gradebook | ||
| LEARNER_HOME_MICROFRONTEND_URL, # frontend-app-learner-dashboard | ||
| LEARNING_MICROFRONTEND_URL, # frontend-app-learning | ||
| ] |
There was a problem hiding this comment.
These changes should be a no-op.
pwnage101
commented
Aug 21, 2025
Comment on lines
74
to
77
| # CORS CONFIG | ||
| CORS_ORIGIN_WHITELIST = [ | ||
| 'http://localhost:1989', # frontend-app-enterprise-checkout | ||
| 'http://localhost:1991', # frontend-app-admin-portal |
There was a problem hiding this comment.
The fixes are in this file only. The other stuff I just added on a whim.
iloveagent57
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.