This repository was archived by the owner on Jun 2, 2021. It is now read-only.
feat(package): add CSRF token management #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglashall
force-pushed
the
douglashall/csrf
branch
2 times, most recently
from
cd9c3fc to
761eca5
Compare
douglashall
force-pushed
the
douglashall/csrf
branch
3 times, most recently
from
770b2f6 to
45b336e
Compare
douglashall
force-pushed
the
douglashall/csrf
branch
2 times, most recently
from
78c538d to
400045e
Compare
robrap
reviewed
Nov 13, 2018
| }; | ||
|
|
||
| authenticatedAPIClient.getCsrfToken = apiHostname => | ||
| authenticatedAPIClient.get(`https://${apiHostname}${authenticatedAPIClient.csrfTokenApiPath}`); |
There was a problem hiding this comment.
Do we need http support for local dev environment? Probably not a blocker, but just curious about local development.
| const url = new Url(request.url); | ||
| const { hostname } = url; | ||
| const csrfToken = csrfTokens[hostname]; | ||
| if (!csrfToken) { |
There was a problem hiding this comment.
Maybe simpler to follow if you start with if (csrfToken) and set header and return early. Then the rest of the method would be used for the queue and promise.
| const originalRequest = request; | ||
| const isAuthUrl = authenticatedAPIClient.isAuthUrl(originalRequest.url); | ||
| const isAccessTokenExpired = authenticatedAPIClient.isAccessTokenExpired(); | ||
| if (!isAuthUrl && isAccessTokenExpired) { |
There was a problem hiding this comment.
Nit: Similar comment in terms of possibly inverting the if and returning earlier.
| }); | ||
| expects(client); | ||
|
|
||
| if (expectHeaderSet) { |
douglashall
force-pushed
the
douglashall/csrf
branch
2 times, most recently
from
18ca4e9 to
d91a223
Compare
robrap
approved these changes
Nov 14, 2018
douglashall
force-pushed
the
douglashall/csrf
branch
from
d91a223 to
5bcd094
Compare
douglashall
force-pushed
the
douglashall/csrf
branch
from
5bcd094 to
e9f9b9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.