-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements + Unit Tests for Pin-Placement Odb
Steps
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donn
changed the title
Odb Script Enhancement + Unit Testing
Enhancements + Unit Tests for Pin-Placement Nov 6, 2023
Odb
Steps
Also, an update for the messages printed when declared macros are not instantiated.
kareefardi
reviewed
Dec 13, 2023
kareefardi
reviewed
Dec 13, 2023
kareefardi
reviewed
Dec 13, 2023
kareefardi
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolbox
objects no longer create a folder immediately upon constructionApplyDEFTemplate
takes precedence over theCustomIOPlacement
, which while it makes less sense in some aspects, matches OpenLane 1KLayout.OpenGUI
:KLAYOUT_EDITOR_MODE
to that enables editor mode in KLayoutOdb.ApplyDEFTemplate
:FP_TEMPLATE_MATCH_MODE
, with valuesstrict
(default) orpermissive
: withstrict
raising an error if any pins are missing from either the template or the design.Odb.CustomIOPlacement
:@min_distance
,@bit_major
, and@bus_major
.openlane/scripts/odbpy/io_place.py
to rely on the new parser + general cleanupVERBOSE
logging in internal plain output mode simply usedprint
Testing
Odb.AddPDNObstructions
Odb.ApplyDEFTemplate
Odb.CustomIOPlacement
Odb.ManualMacroPlacement
Odb.RemovePDNObstructions
Depends on efabless/openlane2-step-unit-tests#11
Depends on efabless/openlane2-ci-designs#12