Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements + Unit Tests for Pin-Placement Odb Steps #250

Merged
merged 24 commits into from
Dec 17, 2023
Merged

Conversation

donn
Copy link
Member

@donn donn commented Nov 5, 2023

  • Toolbox objects no longer create a folder immediately upon construction
  • The Classic flow has been reordered so ApplyDEFTemplate takes precedence over the CustomIOPlacement, which while it makes less sense in some aspects, matches OpenLane 1
  • KLayout.OpenGUI:
    • Added a new boolean config var, KLAYOUT_EDITOR_MODE to that enables editor mode in KLayout
  • Odb.ApplyDEFTemplate:
  • Added FP_TEMPLATE_MATCH_MODE, with values strict (default) or permissive: with strict raising an error if any pins are missing from either the template or the design.
  • Odb.CustomIOPlacement:
    • Completely re-implemented pin placement file parser in Antlr4 for more thorough syntax and semantic checking at https://github.com/efabless/ioplace_parser
    • Formalized concept of annotations; documented three annotations: @min_distance, @bit_major, and @bus_major.
    • Rewrote openlane/scripts/odbpy/io_place.py to rely on the new parser + general cleanup
    • Updated documentation
  • Fixed bug where VERBOSE logging in internal plain output mode simply used print

Testing

  • Added step tests for
    • Odb.AddPDNObstructions
    • Odb.ApplyDEFTemplate
    • Odb.CustomIOPlacement
    • Odb.ManualMacroPlacement
    • Odb.RemovePDNObstructions

Depends on efabless/openlane2-step-unit-tests#11
Depends on efabless/openlane2-ci-designs#12

@donn donn mentioned this pull request Nov 5, 2023
1 task
@donn donn marked this pull request as ready for review November 6, 2023 19:45
@donn donn changed the title Odb Script Enhancement + Unit Testing Enhancements + Unit Tests for Pin-Placement Odb Steps Nov 6, 2023
@donn donn requested a review from kareefardi November 6, 2023 19:45
@donn donn marked this pull request as draft December 6, 2023 22:25
@donn donn marked this pull request as ready for review December 12, 2023 17:21
@donn donn requested a review from kareefardi December 13, 2023 14:53
@donn donn enabled auto-merge (squash) December 17, 2023 11:55
@donn donn merged commit 965d0f6 into main Dec 17, 2023
93 checks passed
@donn donn deleted the odb_unit_tests branch January 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants