[Enhauncement] Added 'for' loops #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
added
enhancement
effectfully
commented
Sep 13, 2019
| withGeqBinOp Div Div y _ = y | ||
| withGeqBinOp _ _ _ z = z | ||
| withGeqUni :: Uni f a1 -> Uni f a2 -> b -> (a1 ~ a2 => b) -> b | ||
| withGeqUni Bool Bool _ y = y |
There was a problem hiding this comment.
The old order was less convenient.
| , case knownUni @f @a of | ||
| Bool -> neq0Expr <|> eqExpr | ||
| Field -> empty | ||
| ] |
There was a problem hiding this comment.
We now have a single expr1 and can share some code, which is convenient.
| , EAppBinOp FLt l <$> (symbol "<" *> exprPoly) | ||
| , EAppBinOp FGe l <$> (symbol ">=" *> exprPoly) | ||
| , EAppBinOp FGt l <$> (symbol ">" *> exprPoly) | ||
| ] |
There was a problem hiding this comment.
There is a TODO above about optimizing comparisonExpr. This fixes the TODO.
| , " end;" | ||
| , "end;" | ||
| , "p" | ||
| ] |
effectfully
force-pushed
the
enhancement/added-for-loops
branch
from
7f24f75 to
f1cc915
Compare
|
I'll merge right away, because I need this downstream, but please @kwxm review the PR anyway, I'll address your comments in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the type of statements to the language (currently a statement is either a let-definition or an assertion) and
forloops that get unrolled during parsing into lists of statements.I also refactored the parser a bit.