[Field] Converting 'negative' finite field elements to negative integers #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
commented
Apr 10, 2020
effectfully
commented
Apr 10, 2020
jakzale
approved these changes
Apr 10, 2020
| p = natVal @p Proxy | ||
| i = GF.fromP f | ||
| asInteger x | ||
| | i < p `Prelude.div` 2 = Just i |
There was a problem hiding this comment.
Does the edge case of i == p `Prelude.div` 2 matter here. I am not sure.
There was a problem hiding this comment.
I started checking that and realized the whole test is broken and doesn't test what it's supposed to. Will fix.
effectfully
force-pushed
the
effectfully/field/drop-IsNegative
branch
from
301b40e to
007a8b7
Compare
|
Ready for another review. Now we have a test that shows how overflows are handled and the old test now uses |
jakzale
approved these changes
Apr 14, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
asInteger (toInteger (-1) :: AField Jubjub.F)givesJust (-1)instead of52435875175126190479447740508185965837690552500527637822603658699938581184512.