Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenApi v3 validator #10

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Kimamisa
Copy link

No description provided.

@Kimamisa
Copy link
Author

Kimamisa commented Aug 3, 2021

up @asimell !

@asimell
Copy link

asimell commented Aug 4, 2021

@Kimamisa thanks for bringing this up. I have just returned from holiday and I'm still catching up with all the other work piled up during summer. At a quick glance this looks fine, but I'll check this more thoroughly and with more concentration in a few hours/days once I get the most urgent things out of the way. Sorry for the delay!

@asimell
Copy link

asimell commented Aug 23, 2021

Hi @Kimamisa,

Looks like openapi-core is still a beta release. We're not entirely happy about adding support to a package that will potentially change quite a bit before it reaches a stable version, so we'll leave this open until openapi-core is stable and then we'll come back to this.

If there comes a huge need and a lot of people need this, we can consider merging this earlier.

@Kimamisa
Copy link
Author

I understand. However, this is a really an added value for RESTInstance. It might help people adopting it, as openapi3 brings today a real value, compared to the v2.

A solution might be to integrate it and mark it as beta while the underlying lib is.

Would that work ?

@asimell
Copy link

asimell commented Aug 23, 2021

After discussing this with @Atihinen , we decided we're still going to keep this open and not take it into next release. Worst case scenario is that we end up with an unstable release candidate that will never make it to stable, because of a new unstable dependency. This could leave us with lots of reverting and loose ends making maintaining more difficult. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants