Skip to content

Conversation

popomore
Copy link
Member

@popomore popomore commented Oct 13, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore popomore requested a review from atian25 October 13, 2017 14:26
@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files           6        6           
  Lines         165      165           
=======================================
  Hits          163      163           
  Misses          2        2
Impacted Files Coverage Δ
lib/cmd/start.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e207052...9bea309. Read the comment docs.

Copy link
Member

@atian25 atian25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctl 是啥的缩写?

@popomore
Copy link
Member Author

好像是 control 吧

@atian25
Copy link
Member

atian25 commented Oct 13, 2017

为什么要这个缩写?简短一点?

回头内网的话,会不会因为 tnpm 的 postinstall 导致 2 个 bin 冲突了?是不是直接在内网做别名就好了?

@popomore
Copy link
Member Author

bin 不是 postinstall 安装的,ctl 应该是业界通用叫法吧。

@atian25
Copy link
Member

atian25 commented Oct 16, 2017

+1

只是觉得 egg-scripts 的别名不那么容易记,增加了额外的记忆成本。

@popomore
Copy link
Member Author

@atian25 那合并了?

@atian25
Copy link
Member

atian25 commented Oct 16, 2017 via email

@popomore popomore merged commit ac40135 into master Oct 16, 2017
@popomore popomore deleted the eggctl branch October 16, 2017 12:06
@popomore
Copy link
Member Author

  • egg-scripts@2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants