feat: support stop --title #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2017
popomore
reviewed
Nov 28, 2017
lib/cmd/stop.js
Outdated
| argv.baseDir = baseDir; | ||
|
|
||
| const pkgInfo = require(path.join(baseDir, 'package.json')); | ||
| argv.title = argv.title || `egg-server-${pkgInfo.name}`; |
There was a problem hiding this comment.
不要默认吧，stop 应该全杀，不然改了 package name 就杀不掉进程了。
可以改成 title 不存在就不传。
|
改了，干掉 baseDir 的支持。 |
popomore
reviewed
Nov 28, 2017
lib/cmd/stop.js
Outdated
| let processList = yield this.helper.findNodeProcess(item => { | ||
| const cmd = item.cmd; | ||
| return cmd.includes('start-cluster'); | ||
| return cmd.includes('start-cluster') && (!argv.title || cmd.includes(`"title":"${argv.title}"`)); |
There was a problem hiding this comment.
这个逻辑看着有点绕，还是先判断 title 吧
argv.title ?
cmd.includes('start-cluster') && cmd.includes(`"title":"${argv.title}"`) :
cmd.includes('start-cluster')
popomore
approved these changes
Nov 28, 2017
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
stop baseDirsupportchange egg to 2