feat: support --ignore-error #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
默认还是支持吧 |
|
那就要做一个命令行参数出去？那也行，明早改改
发自我的 iPhone
… 在 2017年12月7日，21:01，Haoliang Gao ***@***.***> 写道：
默认还是支持吧
—
You are receiving this because you authored the thread
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
嗯，加了这个参数不 exit 就好了 |
atian25
changed the title
|
@popomore 改为 |
popomore
reviewed
Dec 11, 2017
lib/cmd/start.js
Outdated
| } | ||
|
|
||
| * checkStatus({ stderr, timeout }) { | ||
| * checkStatus({ stderr, timeout, 'ignore-error': ignoreError }) { |
popomore
reviewed
Dec 11, 2017
| if (stat && stat.size > 0) { | ||
| const [ stdout ] = yield exec('tail -n 100 ' + stderr); | ||
| this.logger.error(stdout); | ||
| this.logger.error('Start failed, see %s', stderr); |
There was a problem hiding this comment.
这里应该不用改吧，�只是根据参数判断 isSuccess 是否返回 true
There was a problem hiding this comment.
这个算是风格问题吧，感觉放到外面好点吧，while 里面只是循环 stat
|
建议改成 ignore-stderr |
可以 |
|
改为 |
atian25
force-pushed
the
check-status
branch
from
6843537 to
26a8058
Compare
popomore
approved these changes
Dec 12, 2017
|
@popomore 你发吧 |
|
popomore
reviewed
Dec 13, 2017
| // nothing | ||
| } | ||
| isSuccess = ignoreStdErr; | ||
| this.logger.error('Start got error, see %s', stderr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change