Skip to content

refactor: add this.exit to instead of process.exit #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2018
Merged

refactor: add this.exit to instead of process.exit #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1e3b40
refactor: add `this.exit` to instead of `process.exit`
XadillaX Aug 10, 2018
a61e0a7
f
XadillaX Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/cmd/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class StartCommand extends Command {
this.logger.info('%s started on %s', this.frameworkName, msg.data.address);
child.unref();
child.disconnect();
process.exit(0);
this.exit(0);
}
});

Expand All @@ -177,7 +177,7 @@ class StartCommand extends Command {
[ 'SIGINT', 'SIGQUIT', 'SIGTERM' ].forEach(event => {
process.once(event, () => {
signal = event;
process.exit(0);
this.exit(0);
});
});
process.once('exit', () => {
Expand Down Expand Up @@ -246,7 +246,7 @@ class StartCommand extends Command {
if (!isSuccess) {
this.child.kill('SIGTERM');
yield sleep(1000);
process.exit(1);
this.exit(1);
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions lib/command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ class Command extends BaseCommand {

return context;
}

exit(code) {
process.exit(code);
}
}

module.exports = Command;