feat: support eggScriptsConfig in package.json #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
reviewed
Dec 16, 2019
|
|
||
| ```json | ||
| { | ||
| "eggScriptsConfig": { |
There was a problem hiding this comment.
是否改成 config 节点下比较好？
{
"config": {
"eggScripts": { ... }
}
}There was a problem hiding this comment.
现在有 egg, eggPlugin 等一系列配置了，还是先平铺吧？
fengmk2
approved these changes
Dec 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 98.54% 98.56% +0.02%
==========================================
Files 6 6
Lines 206 209 +3
==========================================
+ Hits 203 206 +3
Misses 3 3
Continue to review full report at Codecov.
|
|
2.12.0 |
atian25
reviewed
Apr 28, 2022
| // read argv from eggScriptsConfig in package.json | ||
| if (pkgInfo && pkgInfo.eggScriptsConfig && typeof pkgInfo.eggScriptsConfig === 'object') { | ||
| for (const key in pkgInfo.eggScriptsConfig) { | ||
| if (argv[key] == null) argv[key] = pkgInfo.eggScriptsConfig[key]; |
There was a problem hiding this comment.
结合 https://github.com/node-modules/common-bin/blob/master/lib/helper.js#L180
应该可以通过 node-options--max-http-header-size 的方式来注入 Node 启动参数
目前不支持，提了个 PR：#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change