feat: support pkgInfo.eggScriptsConfig.require #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #48 revert. |
atian25
reviewed
Sep 14, 2021
atian25
reviewed
Sep 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 99.15% 99.60% +0.44%
==========================================
Files 6 6
Lines 237 252 +15
Branches 46 50 +4
==========================================
+ Hits 235 251 +16
+ Misses 2 1 -1
Continue to review full report at Codecov.
|
atian25
reviewed
Sep 14, 2021
atian25
reviewed
Sep 14, 2021
atian25
reviewed
Sep 14, 2021
lib/command.js
Outdated
| } | ||
|
|
||
| // read `egg.require` from package.json | ||
| if (argv.require && Array.isArray(argv.require)) { |
There was a problem hiding this comment.
这段是不是该放在 for 前面，不然 pkgInfo 的 require 和 --require 会覆盖？我们应该是需要合并。
atian25
reviewed
Sep 14, 2021
atian25
approved these changes
Sep 14, 2021
atian25
reviewed
Sep 14, 2021
| } | ||
| } | ||
|
|
||
| delete argv.require; |
There was a problem hiding this comment.
argv.require 有哪里插入到 execArgvObj.require 了么？（不确定 common-bin 里面的逻辑是否执行了）
下面那个单测，多加个 --require 验证下是否合并了。
There was a problem hiding this comment.
这边，这样顺便也解决了 --require 只能传递全路径的易用性（并且兼容以前的全路径传递），两边合并下作为 execObject 传递逻辑上清晰一些
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
support:
The current
pkgInfo.eggScriptConfig.requireneed to provide full path, this pr aims to support relative path & npm pkg.