Skip to content

Conversation

WJayWJay
Copy link
Contributor

@WJayWJay WJayWJay commented Feb 15, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  1. in some terminals, command ps result may be truncated

@WJayWJay
Copy link
Contributor Author

@atian25 @fengmk2 can process it ??

@atian25 atian25 requested a review from hyj1991 February 22, 2022 06:38
@hyj1991
Copy link
Member

hyj1991 commented Feb 22, 2022

ps -eo and ps -wwo output different content, could you please add the test for this pr?

'wmic Path win32_process Where "Name = \'node.exe\'" Get CommandLine,ProcessId' :
// command, cmd are alias of args, not POSIX standard, so we use args
'ps -eo "pid,args"';
'ps -wweo "pid,args"';
Copy link
Member

@fengmk2 fengmk2 Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实老的命令会截断输出

image

修复之后

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-w Use 132 columns to display information, instead of the default which is your window size. If the -w option is specified more than once, ps will use as many columns as
necessary without regard for your window size. When output is not to a terminal, an unlimited number of columns are always used.

@fengmk2 fengmk2 merged commit ef5496d into eggjs:master Mar 8, 2022
@fengmk2
Copy link
Member

fengmk2 commented Mar 8, 2022

2.15.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants