Integration with rspec/mocking

[mcandre]

I'm not sure how contracts should integrate with rspec tests and mocking, especially stubbed things and weird testing calls where you try to send nil to a method that expects a String. Sometimes when I insert a contract, the rspec tests break, and I'm not sure whether this means I've discovered a new edge case, or whether Contracts is simply being incompatible with rspec.

For now, I'm treating rspec tests as sacrosanct and omitting contracts for some of my methods (e.g. initializers #11).

[egonSchiele]

You might be running into issues because rspec wraps classes in it's own class. Take a look at the specs for this project too see how to use contracts + rspec together.

[mcandre]

The recent v0.2.0 changes have greatly improved how contracts works, but mocking still presents a problem for contracts. I currently have to Or[DesiredType, RSpec::Mocks::Mock] contracts for methods I wish to mock.

It just so happens that mock objects have a name attribute, a string of the original type. So it should be possible for contracts.ruby to check that mocked objects are of the right type.

[egonSchiele]

Argh, I still haven't had time to work on this. If you submit a pull request, I'll merge it.

[waterlink]

To me this sounds like a topic for creating so called plugin gem, contracts-rspec, because I'm pretty sure the same (or similar) problem happens with other mocking frameworks and including knowledge how to deal with them in one gem is too much.

WDYT @egonSchiele, @mcandre ?

[mcandre]

Any solution is better than no solution I suppose

[egonSchiele]

I agree, seems like this would add a lot of rspec-specific code to this gem.

[alex-fedorov]

Got it running: https://github.com/waterlink/contracts-rspec You might be able to use now instance_double(YourClassNameHere) and it will pass contract YourClassNameHere.

[egonSchiele]

Can I close this issue @waterlink @mcandre ? Is the contracts-rspec solution satisfactory?

[alex-fedorov]

And now we have 2 solutions: contracts-rspec and override_validator(:class)

So we should be safe to close this issue.
On Jul 24, 2015 12:57 AM, "Aditya Bhargava" notifications@github.com
wrote:

Can I close this issue @waterlink https://github.com/waterlink @mcandre
https://github.com/mcandre ? Is the contracts-rspec solution
satisfactory?

—
Reply to this email directly or view it on GitHub
#14 (comment)
.