New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$variable naming & comments #725
Conversation
Mostly changing to $naming scheme for jQuery objects and adding more comments.
bind() is deprecated. Use on() instead.
Changed the default selectedText to be "# of # selected" so that developers will be aware that this form is available. (It always has been available..)
I guess GitHub will not let me do a squash PR if I am bringing over a feature branch I created. ? Sorry, I intended to do a squash commit. Thank you for your generous patience w/ me. |
To squash it and have it reflected on the PR you would rebase and then force push the branch. The changes would be reflected in the PR automatically. |
Thanks. I wish I had your skill with Git and GitHub. I have done several online tutorials and read a lot about Git, but I still struggle w/ it. |
I've just been using it for a few years. Have you used any version control software other than git, like SVN? |
As I am a hobbiest developer (just do this in my spare time), I just do not have the experience with it. I have done a little bit with the check out/check in type of version control systems in the past (I think this is the SVN model).... most would be considered outdated/obsolete by today's standards. |
Mostly a variable re-naming and commenting update.
Updated version number to 3.0.0 in code heading
Updated jQuery version dependency to 1.7+ due to deprecation of
$().delegate & $().bind()
, and use of$().on()
insteadDetailed comments for each option to explain the permitted value types and the intended use of the option.
Switch default for selectedText option to be
# of # selected
to ensure that developers know that this form is supported.Follow the popular convention of prefixing variable names of jQuery objects with a dollar sign for more clarity.
Use local variables for properties fetched more than once.
Ditch use of
$().bind()
in favor of$().on()
, as bind is deprecated.Unit tests have been updated.