-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector Parameters Update: Central Barrel Hcal #562
Comments
Hey Chao! Thanks for putting this together! Out of curiosity: what are the central, LD, and HD sections here? |
I think Barrel HCal has three sections: Lepton Direction (LD) + Central + Hadron Direction (HD). The central section is thicker (smaller inner radius). |
The central barrel HCAL is one continuous detector, there are not three sections and the entire detector has the same inner and outer radius. |
Ah - I see what you are referring to now, sorry for the confusion. I was thinking this was interpreted as separate longitudinal sections. OK I think it's clear what we need to update now. |
…le (#588) ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [X] Bug fix (issue #562 ) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? None. The changes here are contained to the barrel HCAL geometry alone, and then only the size of the outer HCAL mother volume. The only actual effect is on the outer HCAL mother volume, which was reduced in size. ### Does this PR change default behavior? No. The actual outer HCAL detector geometry is unchanged. NOTE: This review found that some of the parameters in the Detector Table are incorrect. These changes will allow the proper values to be calculated from the simulation input, but they won't match the Detector Table until that table is updated. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Chao Peng <pengc2010@gmail.com> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
A series of smaller issues from #552
det
: new value from 2023/09/27 parameter tablesim
: current simulation value as of 2023/10/11template_var
: from which we extract the sim value in compact files.Empty
means we do not know.stat
:Correct
,Missing
, orMismatched
Please implement the new detector parameters, and try to fill in the
template_var
for theMissing
ones if you think it's important for future simulation/design comparison.Here is the detailed report for this detector subsystem:
The text was updated successfully, but these errors were encountered: