Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector Parameters Update: Central Barrel Hcal #562

Closed
Chao1009 opened this issue Oct 12, 2023 · 5 comments
Closed

Detector Parameters Update: Central Barrel Hcal #562

Chao1009 opened this issue Oct 12, 2023 · 5 comments
Assignees
Labels

Comments

@Chao1009
Copy link
Contributor

Chao1009 commented Oct 12, 2023

A series of smaller issues from #552
det: new value from 2023/09/27 parameter table
sim: current simulation value as of 2023/10/11
template_var: from which we extract the sim value in compact files. Empty means we do not know.
stat: Correct, Missing, or Mismatched

Please implement the new detector parameters, and try to fill in the template_var for the Missing ones if you think it's important for future simulation/design comparison.

Here is the detailed report for this detector subsystem:

CENTRAL DETECTOR, Barrel Hadron Calorimeter, : 
                           det    sim                  template_var        stat
Length (cm)              570.0  635.6         {{HcalBarrel_length}}  Mismatched
Inner Radius (cm)        180.0  177.0           {{HcalBarrel_rmin}}  Mismatched
Outer Radius (cm)        267.0  270.0           {{HcalBarrel_rmax}}  Mismatched
Offset from Center (cm)    0.0    NaN                         Empty     Missing
Physical Start (cm)     -285.0 -316.0  -{{HcalBarrelBackward_zmax}}  Mismatched
Physical End (cm)        285.0  319.6    {{HcalBarrelForward_zmax}}  Mismatched

CENTRAL DETECTOR, Barrel Hadron Calorimeter, Central Section: 
                           det  sim template_var     stat
Length (cm)              300.0  NaN        Empty  Missing
Inner Radius (cm)        180.0  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm)  -35.0  NaN        Empty  Missing
Physical Start (cm)     -185.0  NaN        Empty  Missing
Physical End (cm)        115.0  NaN        Empty  Missing

CENTRAL DETECTOR, Barrel Hadron Calorimeter, HD Section: 
                           det  sim template_var     stat
Length (cm)              170.0  NaN        Empty  Missing
Inner Radius (cm)        194.0  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm)  200.0  NaN        Empty  Missing
Physical Start (cm)      115.0  NaN        Empty  Missing
Physical End (cm)        285.0  NaN        Empty  Missing

CENTRAL DETECTOR, Barrel Hadron Calorimeter, LD Section: 
                           det  sim template_var     stat
Length (cm)              100.0  NaN        Empty  Missing
Inner Radius (cm)        194.0  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm) -235.0  NaN        Empty  Missing
Physical Start (cm)     -285.0  NaN        Empty  Missing
Physical End (cm)       -185.0  NaN        Empty  Missing
@Chao1009 Chao1009 changed the title Detector Parameter Update: Central Barrel Hcal Detector Parameters Update: Central Barrel Hcal Oct 12, 2023
@Chao1009 Chao1009 added topic: barrel Mid-rapidity detectors topic: calorimetry labels Oct 12, 2023
@ruse-traveler
Copy link

Hey Chao! Thanks for putting this together! Out of curiosity: what are the central, LD, and HD sections here?

@Chao1009
Copy link
Contributor Author

Hey Chao! Thanks for putting this together! Out of curiosity: what are the central, LD, and HD sections here?

I think Barrel HCal has three sections: Lepton Direction (LD) + Central + Hadron Direction (HD). The central section is thicker (smaller inner radius).

@johnlajoie
Copy link
Contributor

The central barrel HCAL is one continuous detector, there are not three sections and the entire detector has the same inner and outer radius.

@Chao1009
Copy link
Contributor Author

I didn't really look into the plugin, but from the cross-sectional view, the central part has a smaller inner radius.
image

@johnlajoie
Copy link
Contributor

Ah - I see what you are referring to now, sorry for the confusion. I was thinking this was interpreted as separate longitudinal sections. OK I think it's clear what we need to update now.

github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2024
…le (#588)

### Briefly, what does this PR introduce?


### What kind of change does this PR introduce?
- [X] Bug fix (issue #562 )
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
None. The changes here are contained to the barrel HCAL geometry alone,
and then only the size of the outer HCAL mother volume. The only actual
effect is on the outer HCAL mother volume, which was reduced in size.

### Does this PR change default behavior?
No. The actual outer HCAL detector geometry is unchanged. 

NOTE: This review found that some of the parameters in the Detector
Table are incorrect. These changes will allow the proper values to be
calculated from the simulation input, but they won't match the Detector
Table until that table is updated.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chao Peng <pengc2010@gmail.com>
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@veprbl veprbl closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants