Skip to content

Conversation

ned29
Copy link
Contributor

@ned29 ned29 commented Aug 15, 2018

No description provided.

Copy link
Contributor

@tobiasake tobiasake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@erik-edling erik-edling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had one super tiny comment :)

mockClient.when(request().withMethod("POST").withPath(REST_ENDPOINT)).respond(response().withStatusCode(201));
mockClient.when(request().withMethod("POST").withPath(REST_ENDPOINT_AUTH))
mockClient.when(request().withMethod("POST").withPath(REST_ENDPOINT_AUTH).withHeader("Authorization", "Basic TXkgbW90aGVyIGhhcyAyIGNhdHMgYW5kIHRoZXkgYXJlIGNyYXp5"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too long line

Copy link
Contributor

@erik-edling erik-edling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ned29 ned29 merged commit 0f5387e into eiffel-community:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants