Skip to content

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

fixes: #288

Description of the Change

This will enable us to run both versions of ETOS using the same ETOS cluster.

Alternate Designs

None really.

Possible Drawbacks

Lots of code that needs to be removed later, but the ability to use the same cluster to run both versions of ETOS is a significant improvement.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson tobias.persson@axis.com

@t-persson t-persson requested a review from a team as a code owner October 10, 2024 12:06
@t-persson t-persson requested review from fredjn and andmat900 and removed request for a team October 10, 2024 12:06
@t-persson
Copy link
Collaborator Author

The routing key tag change is problematic when running in the controller environment. Must fix that before merge

@andmat900
Copy link
Contributor

Regarding this:

This will enable us to run both versions of ETOS using the same ETOS cluster.

Please describe in a README (or similar) how this separation is designed to work. Not very clear just by reading the code. It would help understand potential problems, some of which we already seen (e. g. routing tagging).

@t-persson
Copy link
Collaborator Author

Regarding this:

This will enable us to run both versions of ETOS using the same ETOS cluster.

Please describe in a README (or similar) how this separation is designed to work. Not very clear just by reading the code. It would help understand potential problems, some of which we already seen (e. g. routing tagging).

There is no real separation in this code, we just make sure to deploy the suite starter so that the ETOS API can send a TERCC that's being picked up and not ignored.

@t-persson t-persson requested a review from fredjn November 27, 2024 08:50
@t-persson t-persson merged commit aa5f76a into eiffel-community:main Nov 27, 2024
@t-persson t-persson deleted the add-suite-starter branch November 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy suite started with the Cluster resource in the ETOS controller
3 participants