Skip to content

Update environment request status on errors #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Update environment request status on errors #319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92412fc
Update environment provider status on errors
andmat900 Dec 2, 2024
eb6f692
code review changes
andmat900 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions internal/controller/environmentrequest_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,20 +116,34 @@ func (r *EnvironmentRequestReconciler) reconcile(ctx context.Context, environmen
logger.V(1).Info("environment provider count", "active", len(environmentProviders.activeJobs), "successful", len(environmentProviders.successfulJobs), "failed", len(environmentProviders.failedJobs))

// Check providers availability
// TODO: Update status
providers := etosv1alpha1.Providers{
IUT: environmentrequest.Spec.Providers.IUT.ID,
ExecutionSpace: environmentrequest.Spec.Providers.ExecutionSpace.ID,
LogArea: environmentrequest.Spec.Providers.LogArea.ID,
}
if err := checkProviders(ctx, r, environmentrequest.Namespace, providers); err != nil {
return err
meta.SetStatusCondition(&environmentrequest.Status.Conditions,
metav1.Condition{
Status: metav1.ConditionFalse,
Type: StatusReady,
Message: fmt.Sprintf("Provider check failed: %s", err.Error()),
Reason: "Failed",
})
logger.Error(err, "Error occurred while checking provider status")
return r.Status().Update(ctx, environmentrequest)
}

// Reconcile environment provider
// TODO Update status
if err := r.reconcileEnvironmentProvider(ctx, environmentProviders, environmentrequest); err != nil {
return err
meta.SetStatusCondition(&environmentrequest.Status.Conditions,
metav1.Condition{
Status: metav1.ConditionFalse,
Type: StatusReady,
Message: fmt.Sprintf("Environment provider reconciliation failed: %s", err.Error()),
Reason: "Failed",
})
logger.Error(err, "Error occurred while reconciling environment provider")
return r.Status().Update(ctx, environmentrequest)
}

if environmentProviders.failed() {
Expand Down