Revert "Remove environmentRequest dependency for Environment" #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c07b4bd.
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
andmat900
reviewed
Dec 3, 2024
| } | ||
| releaser := r.releaseJob(environment, *image) | ||
| releaser := r.releaseJob(environment, environmentRequest) | ||
| fmt.Println(releaser) |
There was a problem hiding this comment.
This is a revert.
andmat900
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #324
I didn't think about the bigger picture here. Our environment providers may required a few items from the dataset in particular in order to run their cleanup operations.
The environment request resource must exist for an environment to be cleaned up properly without manual intervention. Having the environment request be required by the environment_controller will enforce this even if it may seem unnecessary to do.
A new PR will be uploaded where we add finalizers to the environmentrequests so that they may not be deleted before the environment has been cleaned up.