ProviderReconciler: health check scheduling #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andmat900
requested review from
t-persson and
fredjn
and removed request for
a team
andmat900
force-pushed
the
20241218_scheduled_checks_simplified
branch
from
77bcca5 to
75934d7
Compare
t-persson
requested changes
Jan 15, 2025
fredjn
approved these changes
Jan 15, 2025
t-persson
requested changes
Jan 17, 2025
| return ctrl.Result{}, err | ||
| } | ||
|
|
||
| meta.SetStatusCondition(&provider.Status.Conditions, metav1.Condition{Type: StatusAvailable, Status: metav1.ConditionTrue, Reason: "OK", Message: "Provider is up and running"}) |
There was a problem hiding this comment.
Just doing SetStatusCondition does nothing, r.Status().Update(...) must be called for it to write the status back on the resource.
There was a problem hiding this comment.
SetStatusCondition now placed before r.Status().Update().
| if time.Until(next) > 0 { | ||
| return ctrl.Result{RequeueAfter: time.Until(next)}, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
We should set LastHealthCheckTime on the provider resource here at the start, so that we have it set even on failures.
There was a problem hiding this comment.
LastHealthCheckTime placed in the beginning of the function.
t-persson
approved these changes
Jan 20, 2025
andmat900
added a commit
to andmat900/etos
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
This change introduces a new scheduling logic for provider health checks. The health checks are scheduled dynamically based on the provider's health check interval setting and the previous health check result.
Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Andrei Matveyeu, andrei.matveyeu@axis.com