Block environmentrequest deletion and propagate deletes #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
t-persson
force-pushed
the
block-environmentrequest-delete
branch
from
c642632 to
d128cc1
Compare
andmat900
reviewed
Jan 16, 2025
fredjn
requested changes
Jan 20, 2025
t-persson
force-pushed
the
block-environmentrequest-delete
branch
from
a20f9d7 to
14268b5
Compare
|
Rebased |
t-persson
force-pushed
the
block-environmentrequest-delete
branch
from
14268b5 to
f186341
Compare
andmat900
reviewed
Feb 19, 2025
andmat900
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
fixes: #362
Description of the Change
When an environment request gets deleted, delete all environments connected to it and wait for them to be deleted before getting removed from Kubernetes. This will ensure that deletions of environment requests always propagate to the environments. Before this only deletion of testruns would, sometimes, propagate to environments.
This also fixes another issue in that the environment controller has a dependency to the environment request but it does not always exist in Kubernetes due to not blocking its deletion.
Alternate Designs
Nope
Possible Drawbacks
More objects will get stuck if an environment cannot be released but it's better than crashing.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson tobias.persson@axis.com