Skip to content

Ensure that the dataset is passed in as a list #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Ensure that the dataset is passed in as a list #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ed0cc5
Ensure that the dataset is passed in as a list
t-persson Jan 17, 2025
2d33a9b
Make sure we can start v1alpha
t-persson Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/src/etos_client/etos/v0/subcommands/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Start(SubCommand):
"""
Client for executing test automation suites in ETOS.

Usage: etosctl testrun v0 start [-v|-vv] [options] -i IDENTITY -s TEST_SUITE <cluster>
Usage: etosctl testrun v0 start [-v|-vv] [options] [--dataset=DATASET]... -i IDENTITY -s TEST_SUITE <cluster>

Options:
-h, --help Show this help message and exit
Expand Down
5 changes: 3 additions & 2 deletions cli/src/etos_client/etos/v1alpha/subcommands/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

from etos_client.types.result import Conclusion, Verdict
from etos_client.etos.v1alpha.etos import Etos
from etos_client.sse.v1.client import SSEClient

from etosctl.command import SubCommand
from etosctl.models import CommandMeta
Expand All @@ -31,7 +32,7 @@ class Start(SubCommand):
"""
Client for executing test automation suites in ETOS.

Usage: etosctl testrun v1alpha start [-v|-vv] [options] -i IDENTITY -s TEST_SUITE <cluster>
Usage: etosctl testrun v1alpha start [-v|-vv] [options] [--dataset=DATASET]... -i IDENTITY -s TEST_SUITE <cluster>

Options:
-h, --help Show this help message and exit
Expand Down Expand Up @@ -68,7 +69,7 @@ def run(self, args: dict) -> None:
warnings.warn("This is an alpha version of ETOS! Don't expect it to work properly")
self.logger.info("Running in cluster: %r", args["<cluster>"])

etos = Etos(args)
etos = Etos(args, SSEClient(args["<cluster>"]))
result = etos.run()
if result.conclusion == Conclusion.FAILED:
sys.exit(result.reason)
Expand Down