fix KeyError when optional CLI args are omitted

[andmat900]

Applicable Issues

• KeyError when optional CLI arg --parent-activity is omitted #359

Description of the Change

The change modifies the from_args method to handle missing optional arguments more robustly by using conditional expressions to set default values. This ensures that the RequestSchema is created with appropriate default values when these arguments are not provided.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Andrei Matveyeu, andrei.matveyeu@axis.com

[t-persson]

I am not seeing the problem that you are describing in the issue.

python -m etosctl testrun start -s http://suite.json --identity=pkg:hello --dataset='{}' https://etos

args = {'--artifact-dir': None,
 '--dataset': ['{}'],
 '--download-reports': None,
 '--execution-space-provider': None,
 '--help': False,
 '--identity': 'pkg:hello',
 '--iut-provider': None,
 '--log-area-provider': None,
 '--no-tty': False,
 '--parent-activity': None,
 '--report-dir': None,
 '--test-suite': 'http://suite.json',
 '--version': False,
 '--workspace': None,
 '-v': 0,
 '<args>': ['-s', 'http://suite.json', '--identity=pkg:hello', '--dataset={}', 'https://etos'],
 '<cluster>': 'https://etos',
 '<command>': 'start',
 'start': True,
 'testrun': True,
 'v0': True}

RequestSchema(artifact_id=None artifact_identity='pkg:hello' parent_activity=None test_suite_url='http://suite.json' dataset={} execution_space_provider='default' iut_provider='default' log_area_provider='default')

[t-persson]

Was able to reproduce it now. You are running v1alpha.
Since the RequestSchema has diverged please create a RequestSchema for v1alpha instead of changing the v0 RequestSchema

[andmat900]

Was able to reproduce it now. You are running v1alpha. Since the RequestSchema has diverged please create a RequestSchema for v1alpha instead of changing the v0 RequestSchema

Added. The v1alpha schema code is duplicated to allow for easier modifications, independent from v0.

[andmat900]

Currently, the only difference from the v0 schema is the absence of parent_activity. The code is duplicated so that it is easier to modify it (i. e. independently from v0).