Skip to content

Conversation

andmat900
Copy link
Contributor

@andmat900 andmat900 commented Feb 19, 2025

Applicable Issues

Description of the Change

This change makes sure all environment variables are passed from EnvironmentProviderJobConfig to the environment provider job.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Andrei Matveyeu, andrei.matveyeu@axis.com

@andmat900 andmat900 requested a review from a team as a code owner February 19, 2025 08:54
@andmat900 andmat900 requested review from t-persson and fredjn and removed request for a team February 19, 2025 08:54
@t-persson
Copy link
Collaborator

Please verify that all JobConfig variables are being passed to the environment provider. For instance the RoutingKeyTag does not seem to be passed either.

Change-Id: If51c1365cb21bce0373c38bb3de42a1374414ef2
@andmat900
Copy link
Contributor Author

Please verify that all JobConfig variables are being passed to the environment provider. For instance the RoutingKeyTag does not seem to be passed either.

I checked what variables are used by the environment provider. Let's check what needs to be passed/fixed here or in the environment provider:

  • routing tag: does not seem to be used in the environment provider. Should it be added passed for future implementation? If so what variable name?

  • ETOS_GRAPHQL_SERVER: is read by environment provider via dataset/etos-library. Can be removed from EnvironmentProviderJobConfig?

  • ETOS_API: is sometimes set from envvar/sometimes from etos library. What is correct?

src/environment_provider/environment_provider.py:            f"{os.getenv('ETOS_API')}/v1alpha/testrun/{environment_id}",
src/execution_space_provider/utilities/list.py:                    "ETOS_API": self.etos.debug.etos_api,
src/execution_space_provider/utilities/external_provider.py:                "ETOS_API": self.etos.debug.etos_api,
  • ETOS_WAIT_FOR_ variables : similar (duplicate?) variants are used in environment provider: ENVIRONMENT_PROVIDER_WAIT_FOR_. Should be fixed in environment provider?
src/iut_provider/utilities/external_provider.py:            end = os.getenv("ENVIRONMENT_PROVIDER_WAIT_FOR_IUT_TIMEOUT")
  • DEV: not set by EnvironmentProviderJobConfig. Should it be passed from controller?

Change-Id: I9bc5f4343f4d0864eacc3fce2ff79ebf5838f6e7
@andmat900 andmat900 force-pushed the 20250219_environment_provider_job_config branch from 5d86e7b to 7ee3566 Compare February 19, 2025 10:44
@andmat900 andmat900 changed the title pass ETOS_WAIT_FOR_* variables to environment provider job pass missing variables to environment provider job Feb 19, 2025
Change-Id: I8e312ee3c33a0ec07d9d0f07a69ce68da8a61d85
Change-Id: I357c13e43197d346ebb17c4137ad49de235418b8
Change-Id: Ic2a64dc7cfec616378b392d50348399487dca567
@andmat900 andmat900 requested a review from t-persson February 20, 2025 09:54
@andmat900 andmat900 merged commit cd35709 into eiffel-community:main Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants