Skip to content

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

Description of the Change

Also add CPU limits and requests in the suite runner template

I probably added too high limits for the initContainers, but since the pod will have its real limit and requests set to the highest request we will always get the LogListener container + the ESR container anyways because it's higher than the initContainers.
More on how Kubernetes calculates resources can be found here

When Kubernetes support for Pod resources is generally available we should move over to use those.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson tobias.persson@axis.com

Also add CPU limits and requests in the suite runner template
@t-persson t-persson requested a review from a team as a code owner February 21, 2025 11:56
@t-persson t-persson requested review from fredjn and andmat900 and removed request for a team February 21, 2025 11:56
@t-persson t-persson merged commit 0d1a47c into eiffel-community:main Feb 21, 2025
@t-persson t-persson deleted the add-limits-to-all-containers branch February 21, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants