Restart deployments and statefulsets if configurations have changed #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding or updating an annotation to the spec Kubernetes will automatically recreate the deployments and statefulsets causing the pods to restart and get the new configurations. This way of doing it is the same way as kubectl rollout restart.
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
Setting the annotation on the deployment/statefulset did not automatically re-deploy the pods. Setting it on the podspec does.
andmat900
approved these changes
Apr 8, 2025
fredjn
pushed a commit
to fredjn/etos
that referenced
this pull request
Aug 5, 2025
…iffel-community#398) * Restart deployments and statefulsets if configurations have changed By adding or updating an annotation to the spec Kubernetes will automatically recreate the deployments and statefulsets causing the pods to restart and get the new configurations. This way of doing it is the same way as kubectl rollout restart. * Set the annotation on the pod instead Setting the annotation on the deployment/statefulset did not automatically re-deploy the pods. Setting it on the podspec does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
By adding or updating an annotation to the spec Kubernetes will automatically recreate the deployments and statefulsets causing the pods to restart and get the new configurations. This way of doing it is the same way as kubectl rollout restart.
I've not been able to test this yet since my local environment is busted at the moment so this change may not work yet
Alternate Designs
None that I could think of.
Possible Drawbacks
The one thing I thought of (and am going to test) is that we might get stuck in a reconcile loop. I don't know how or why but we've had these loops before and we need to verify that this change does not cause any.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson tobias.persson@axis.com