Skip to content

Conversation

andmat900
Copy link
Contributor

Applicable Issues

Description of the Change

This change adds the possibility to set volatile etcd parameters like image version, resource usage in the cluster spec.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Andrei Matveyeu, andrei.matveyeu@axis.com

Change-Id: I381742c729f849e88ef274492836c30d3ae832b3
@andmat900 andmat900 requested a review from a team as a code owner August 13, 2025 13:09
@andmat900 andmat900 requested review from t-persson and fredjn and removed request for a team August 13, 2025 13:10
Change-Id: If0034baf50bf4b072863e32667bb482636564a47
Change-Id: I3a28026916bdfb9bc2f574249fc2c886d0aa4fc5
Change-Id: Ic30b776a267b84f3d1fd8f8fcbf2ae7af975acc1
Change-Id: Icc0dbcad0d380b5e8aa84a6fd75e8a9ec98e9bf4
Change-Id: Ifd83ec70f7dc6e81fe50b118e9d359c07080872f
Change-Id: Ied1bf81e57dac907786c62e063a7821a09b2d3fd
Change-Id: I6d03e946b82448f6a63754bc2128a70822b5d977
Copy link
Collaborator

@t-persson t-persson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only happened to glance at this. Probably wont read any updates to this pr.

Comment on lines 113 to 125
RequestsMemory string `json:"requestsMemory"`
// Parameter is ignored if Deploy is set to true.
// +kubebuilder:default="300m"
// +optional
RequestsCPU string `json:"requestsCPU"`
// Parameter is ignored if Deploy is set to true.
// +kubebuilder:default="768Mi"
// +optional
LimitsMemory string `json:"limitsMemory"`
// Parameter is ignored if Deploy is set to true.
// +kubebuilder:default="300m"
// +optional
LimitsCPU string `json:"limitsCPU"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we really need to add these, then they should use the same parameters that can be found in the statefulset spec so that the parameters look and feel the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. The resources element is now identical to statefulset spec. Example:

  database:
    deploy: true
    etcd:
      image: "quay.io/coreos/etcd:v3.5.19"
      resources:
        limits:
          memory: "512Mi"
          cpu: "200m"
        requests:
          memory: "512Mi"
          cpu: "200m"

Change-Id: I82021e7f566b6454a8505b1649f1a55085dcfc8a
Change-Id: I6d39d9fb3eb4b7d5c8b02f5d6bc5f5c05e35135d
Change-Id: I726e36da4555d5f580c245522d85a2395d863ee9
Change-Id: If706ec0014fbd09fbf53afc051b570e56f2e2739
Change-Id: Iaca98bc5cdf6d5c6443e0c626bdbab83d8514097
Change-Id: I992075720443275124a0cbdab4ce85cb2d9861d3
Change-Id: I6e88d83baae405a72fb8b76b146893af208729fd
Change-Id: Ib432e4dc7628d4a791cc63070cc3a20eef50bcc3
@andmat900 andmat900 merged commit aae1d30 into eiffel-community:main Aug 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants